Validate custom column names#1013
Merged
mattrunyon merged 7 commits intodeephaven:mainfrom Jan 27, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
+ Coverage 41.40% 42.15% +0.74%
==========================================
Files 430 430
Lines 32104 32115 +11
Branches 8040 8053 +13
==========================================
+ Hits 13293 13538 +245
+ Misses 18758 18524 -234
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
previously approved these changes
Jan 12, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Would be nice to add some CustomColumnBuilder tests as well.
Collaborator
Author
Ask and you shall receive The tests found a bug in Tab handling within the monaco editor (monaco was eating the tab). I have the fix for that behavior in this PR. I can split it out if you prefer |
mofojed
requested changes
Jan 19, 2023
mattrunyon
force-pushed
the
custom-column-validation
branch
from
1018abc to
f249e57
Compare
mofojed
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #939
Does not validate that the names aren't duplicates of existing column names, only of existing custom columns. The API seems to allow custom columns that overwrite an existing column name. For example, table with coiumns
A, B, C. Create a custom columnA=CandB=A. All of the columns will display columnC. If you swap the order of the custom columns, thenBwill show the originalAandAwill showC.The API does not allow invalid custom column names (table column validation) or duplicate custom column names.